-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve occupancy testing cluster tests #21595
Improve occupancy testing cluster tests #21595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raju-apple can you please review?
PR #21595: Size comparison from c8a6d37 to 5c2e03c Increases (7 builds for bl602, k32w, linux, telink)
Decreases (1 build for esp32)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but these are marked as "manual tests" right now. Should they be moved into the automated tests set so they actually run in CI?
I honestly don't know the procedure. The people responsible for this should pitch in here? @woody-apple |
Let me rephrase: if the test passes in CI, and is not extremely time-consuming, it should run in CI. |
5c2e03c
to
6b04a5b
Compare
PR #21595: Size comparison from 397d642 to 6b04a5b Increases (3 builds for cc13x2_26x2, linux)
Decreases (4 builds for bl602, cc13x2_26x2, esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Problem
Some OCC tests are dummy tests
Change overview
Improve occupancy testing cluster tests
Testing
chip-tool tests